fix: v3.0→HEAD review 修复 — handler 注册 + review verdict + skill 全文注入
基于庞统+司马懿背靠背 review,修复 6 个问题:
P0 致命:
- A1: _legacy_on_complete 补回 review verdict 处理(approved→done,非 approved→@mention assignee)
- A2: 添加 TaskTypeRegistry.register() 启动初始化(注册 Task/Mail/Toolchain handler)
P1 中等:
- B11-1: RoleSkillSection 从索引提示改为全文注入(对齐设计 §2.3 + BootstrapBuilder 行为)
- A8: retry prompt is_mail 硬编码改走 TaskTypeRegistry handler 判断
P2 低:
- _mail_* 4 个方法添加 DEPRECATED 注释
- ticker.py handler check_completion 代码块缩进对齐(28→24 空格)
测试:394 passed, 0 failed
Review reports: docs/design/review-v3-vs-head-{pangtong,simayi}.md
This commit is contained in:
@@ -5,6 +5,7 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import logging
|
||||
import os
|
||||
from pathlib import Path
|
||||
from typing import Dict, List, Optional
|
||||
|
||||
@@ -79,7 +80,7 @@ class PriorOutputsSection:
|
||||
|
||||
|
||||
class RoleSkillSection:
|
||||
"""段 3:角色 Skill 索引+引导语(D8 决策:不注全文)。"""
|
||||
"""段 3:角色 Skill 全文注入(对齐设计 §2.3 + BootstrapBuilder 行为)。"""
|
||||
|
||||
name: str = "role_skill"
|
||||
priority: int = 30
|
||||
@@ -91,11 +92,16 @@ class RoleSkillSection:
|
||||
f"你的角色:{context.role}",
|
||||
]
|
||||
if skill_name:
|
||||
lines.append(f"对应 Skill:{skill_name}")
|
||||
lines.append(
|
||||
f"请用 read 工具读取 {SKILL_BASE_PATH}/{skill_name}/SKILL.md "
|
||||
"获取完整操作规范。"
|
||||
)
|
||||
skill_path = os.path.join(SKILL_BASE_PATH, skill_name, "SKILL.md")
|
||||
try:
|
||||
with open(skill_path, encoding="utf-8") as f:
|
||||
skill_content = f.read()
|
||||
if skill_content:
|
||||
lines.append(skill_content)
|
||||
else:
|
||||
lines.append(f"(Skill 文件为空:{skill_name})")
|
||||
except FileNotFoundError:
|
||||
lines.append(f"(Skill 文件不存在:{skill_name})")
|
||||
else:
|
||||
lines.append("无对应 Skill 文件,按通用规范执行。")
|
||||
return "\n".join(lines)
|
||||
|
||||
Reference in New Issue
Block a user