diff --git a/docs/design/20-task-type-architecture.md b/docs/design/20-task-type-architecture.md index 70be351..e5cd414 100644 --- a/docs/design/20-task-type-architecture.md +++ b/docs/design/20-task-type-architecture.md @@ -1009,3 +1009,38 @@ handler.post_complete(task_id, agent_id, outcome, db_path) **结论**:L2 的 RoleSkillSection 改为注入索引+引导语(~100 token),引导 Agent 用 `read` 去读 Skill 全文(L3 层)。遵循 Hermes 的渐进式 Skill 加载模式。 --- + +## §19. 审查与验证历史 + +### Step 2-5 背靠背审查(2026-06-10/11) + +Step 2-5(Task 五层架构重构)合并前,庞统和司马懿分别独立完成 v3.0 → HEAD 的背靠背审查。 + +**审查范围**:v3.0 tag → HEAD(6 commits, +1584/-134 行, 9 个文件) + +**关键发现与修复**: + +| # | 问题 | 严重度 | 状态 | +|---|------|--------|------| +| A1 | dispatcher review verdict 处理丢失 | 致命 | ✅ 已修复(PR #24) | +| A2 | Handler 注册初始化缺失 | 致命 | ✅ 已修复 | +| D1 | pre_spawn 返回值未检查 | 严重 | ✅ 已修复(H1 3次重试) | +| D2 | PromptContext 缺少 from_agent/mail_type | 严重 | ✅ 已修复 | +| D5 | _check_reply 语义差异 | 严重 | ✅ 已修复(恢复 tasks 表查询) | +| D3 | inform outcome 白名单 | 轻微 | ⚪ 保留(CRASH_OUTCOMES 已覆盖) | +| D4 | retry prompt 硬编码 | 轻微 | ⚪ 保留(旧方法 deprecated) | +| D6 | 标 done 重试 | 轻微 | ✅ 已修复(统一 _mark_task_status) | + +**Handler 缺陷修复(Step 5 前)**: + +| # | 修复 | 状态 | +|---|------|------| +| H1 | _mark_task_status 3 次重试 | ✅ | +| H2 | review @mention comment_type | ✅ | +| H3 | review 非 approved 保持 review | ✅ | + +**背靠背设计-编码一致性检查**:13 个专题(01-13),4 个严重偏差修复,6 个轻微保留。 + +**详细审查记录**:见 `archive-3.0/` 目录。 + +--- diff --git a/docs/design/review-v3-vs-head-pangtong.md b/docs/design/archive-3.0/review-v3-vs-head-pangtong.md similarity index 100% rename from docs/design/review-v3-vs-head-pangtong.md rename to docs/design/archive-3.0/review-v3-vs-head-pangtong.md diff --git a/docs/design/review-v3-vs-head-simayi.md b/docs/design/archive-3.0/review-v3-vs-head-simayi.md similarity index 100% rename from docs/design/review-v3-vs-head-simayi.md rename to docs/design/archive-3.0/review-v3-vs-head-simayi.md diff --git a/docs/design/step5-audit-report.md b/docs/design/archive-3.0/step5-audit-report.md similarity index 100% rename from docs/design/step5-audit-report.md rename to docs/design/archive-3.0/step5-audit-report.md diff --git a/docs/design/step5-impact-analysis.md b/docs/design/archive-3.0/step5-impact-analysis.md similarity index 100% rename from docs/design/step5-impact-analysis.md rename to docs/design/archive-3.0/step5-impact-analysis.md