From 98eb15125d65881dc251340cfce5083d564eed9e Mon Sep 17 00:00:00 2001 From: cfdaily Date: Sat, 13 Jun 2026 08:49:41 +0800 Subject: [PATCH] =?UTF-8?q?chore(docs):=20=E5=BD=92=E6=A1=A3=20=C2=A720=20?= =?UTF-8?q?=E5=AE=A1=E6=9F=A5=E6=96=87=E6=A1=A3=E8=87=B3=20archive-3.0?= =?UTF-8?q?=EF=BC=8C=E8=BF=BD=E5=8A=A0=E5=AE=A1=E6=9F=A5=E5=8E=86=E5=8F=B2?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - review-v3-vs-head-pangtong.md → archive-3.0/ - review-v3-vs-head-simayi.md → archive-3.0/ - step5-audit-report.md → archive-3.0/ - step5-impact-analysis.md → archive-3.0/ - §20 新增 §19 审查与验证历史（关键发现+修复状态汇总） --- docs/design/20-task-type-architecture.md | 35 +++++++++++++++++++ .../review-v3-vs-head-pangtong.md | 0 .../review-v3-vs-head-simayi.md | 0 .../{ => archive-3.0}/step5-audit-report.md | 0 .../step5-impact-analysis.md | 0 5 files changed, 35 insertions(+) rename docs/design/{ => archive-3.0}/review-v3-vs-head-pangtong.md (100%) rename docs/design/{ => archive-3.0}/review-v3-vs-head-simayi.md (100%) rename docs/design/{ => archive-3.0}/step5-audit-report.md (100%) rename docs/design/{ => archive-3.0}/step5-impact-analysis.md (100%) diff --git a/docs/design/20-task-type-architecture.md b/docs/design/20-task-type-architecture.md index 70be351..e5cd414 100644 --- a/docs/design/20-task-type-architecture.md +++ b/docs/design/20-task-type-architecture.md @@ -1009,3 +1009,38 @@ handler.post_complete(task_id, agent_id, outcome, db_path) **结论**：L2 的 RoleSkillSection 改为注入索引+引导语（~100 token），引导 Agent 用 `read` 去读 Skill 全文（L3 层）。遵循 Hermes 的渐进式 Skill 加载模式。 --- + +## §19. 审查与验证历史 + +### Step 2-5 背靠背审查（2026-06-10/11） + +Step 2-5（Task 五层架构重构）合并前，庞统和司马懿分别独立完成 v3.0 → HEAD 的背靠背审查。 + +**审查范围**：v3.0 tag → HEAD（6 commits, +1584/-134 行, 9 个文件） + +**关键发现与修复**： + +| # | 问题 | 严重度 | 状态 | +|---|------|--------|------| +| A1 | dispatcher review verdict 处理丢失 | 致命 | ✅ 已修复（PR #24） | +| A2 | Handler 注册初始化缺失 | 致命 | ✅ 已修复 | +| D1 | pre_spawn 返回值未检查 | 严重 | ✅ 已修复（H1 3次重试） | +| D2 | PromptContext 缺少 from_agent/mail_type | 严重 | ✅ 已修复 | +| D5 | _check_reply 语义差异 | 严重 | ✅ 已修复（恢复 tasks 表查询） | +| D3 | inform outcome 白名单 | 轻微 | ⚪ 保留（CRASH_OUTCOMES 已覆盖） | +| D4 | retry prompt 硬编码 | 轻微 | ⚪ 保留（旧方法 deprecated） | +| D6 | 标 done 重试 | 轻微 | ✅ 已修复（统一 _mark_task_status） | + +**Handler 缺陷修复（Step 5 前）**： + +| # | 修复 | 状态 | +|---|------|------| +| H1 | _mark_task_status 3 次重试 | ✅ | +| H2 | review @mention comment_type | ✅ | +| H3 | review 非 approved 保持 review | ✅ | + +**背靠背设计-编码一致性检查**：13 个专题（01-13），4 个严重偏差修复，6 个轻微保留。 + +**详细审查记录**：见 `archive-3.0/` 目录。 + +--- diff --git a/docs/design/review-v3-vs-head-pangtong.md b/docs/design/archive-3.0/review-v3-vs-head-pangtong.md similarity index 100% rename from docs/design/review-v3-vs-head-pangtong.md rename to docs/design/archive-3.0/review-v3-vs-head-pangtong.md diff --git a/docs/design/review-v3-vs-head-simayi.md b/docs/design/archive-3.0/review-v3-vs-head-simayi.md similarity index 100% rename from docs/design/review-v3-vs-head-simayi.md rename to docs/design/archive-3.0/review-v3-vs-head-simayi.md diff --git a/docs/design/step5-audit-report.md b/docs/design/archive-3.0/step5-audit-report.md similarity index 100% rename from docs/design/step5-audit-report.md rename to docs/design/archive-3.0/step5-audit-report.md diff --git a/docs/design/step5-impact-analysis.md b/docs/design/archive-3.0/step5-impact-analysis.md similarity index 100% rename from docs/design/step5-impact-analysis.md rename to docs/design/archive-3.0/step5-impact-analysis.md