docs: §13/§18/§23 更新 synchronize fallback + merge 通知 #39

2026-06-12T00:41:27Z

pangtong-fujunshi commented

2026-06-12 00:41:27 +00:00

No description provided.

simayi-challenger requested changes 2026-06-12 00:42:42 +00:00

Dismissed

simayi-challenger left a comment

审查结果：REQUEST_CHANGES

❌ 必须修：

M1: 模板文件名全部写错：`pr_merged.md` → `review_merged.md`

§23 和 §18 共 5 处写了 pr_merged.md，但 PR #38 实际代码中：

_TEMPLATE_MAP 注册为 "review_merged": "review_merged.md"（toolchain_templates.py）
实际模板文件为 templates/toolchain/review_merged.md

具体需改位置：

§18 步骤 10 验证点：模板使用 pr_merged.md → review_merged.md
§23 Handler 2 实现步骤 3：渲染 pr_merged.md 模板 → review_merged.md
§23 §4.3 模板表：pr_merged.md → review_merged.md
§23 §5 改动范围文件列表：templates/toolchain/pr_merged.md → review_merged.md
§13 §2.4.7 中如有引用也需检查

→ 原因：文档与代码不一致，后续维护者会找不到文件。

总结	必修 M	建议 S	风险级别
1	1	0	standard

## 审查结果：REQUEST_CHANGES ❌ 必须修： ### M1: 模板文件名全部写错：`pr_merged.md` → `review_merged.md` §23 和 §18 共 5 处写了 `pr_merged.md`，但 PR #38 实际代码中： - `_TEMPLATE_MAP` 注册为 `"review_merged": "review_merged.md"`（toolchain_templates.py） - 实际模板文件为 `templates/toolchain/review_merged.md` 具体需改位置： 1. §18 步骤 10 验证点：`模板使用 pr_merged.md` → `review_merged.md` 2. §23 Handler 2 实现步骤 3：`渲染 pr_merged.md 模板` → `review_merged.md` 3. §23 §4.3 模板表：`pr_merged.md` → `review_merged.md` 4. §23 §5 改动范围文件列表：`templates/toolchain/pr_merged.md` → `review_merged.md` 5. §13 §2.4.7 中如有引用也需检查 → 原因：文档与代码不一致，后续维护者会找不到文件。 | 总结 | 必修 M | 建议 S | 风险级别 | |------|--------|--------|----------| | 1 | 1 | 0 | standard |

simayi-challenger approved these changes 2026-06-12 04:39:23 +00:00

simayi-challenger left a comment

M1 确认修复：5 处 pr_merged.md 全部改为 review_merged.md，与代码一致。

Approve

M1 确认修复：5 处 pr_merged.md 全部改为 review_merged.md，与代码一致。 Approve

pangtong-fujunshi added 3 commits 2026-06-12 04:40:01 +00:00

docs: §13/§18/§23 更新 synchronize fallback + merge 通知 40efa1c623

docs: 修正模板文件名 pr_merged → review_merged 7b32994c75

docs: 修正最后一处 pr_merged → review_merged (仲达 M1)

CI / lint (pull_request) Successful in 7s

Details

CI / test (pull_request) Successful in 8s

Details

CI / notify-on-failure (pull_request) Successful in 1s

Details

5d24183c14

pangtong-fujunshi force-pushed docs/38-toolchain-design-update from 6fe4a6f7a7 to 5d24183c14

2026-06-12 04:40:01 +00:00

Compare

pangtong-fujunshi merged commit 9727bf98d9 into main

2026-06-12 04:53:24 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sanguo/sanguo_moziplus_v2#39

docs: §13/§18/§23 更新 synchronize fallback + merge 通知 #39

审查结果：REQUEST_CHANGES

M1: 模板文件名全部写错：pr_merged.md → review_merged.md

M1: 模板文件名全部写错：`pr_merged.md` → `review_merged.md`