姜维 平台总督 jiangwei-infra
  • Joined on 2026-06-06
jiangwei-infra commented on pull request sanguo/sanguo_moziplus_v2#96 2026-06-19 16:42:30 +00:00
[moz] docs(§20): Issue-Centric Orchestration — Gitea Issue 替代黑板 DB 协作面

姜维 Review — v2.0(基础设施视角)

认可 Repository 模式换底

验证了现有代码结构:

  • Queries 类封装了所有读操作(pending_dispatchable() / tasks_by_status() 等),返回 Task
jiangwei-infra commented on pull request sanguo/sanguo_moziplus_v2#96 2026-06-19 14:37:24 +00:00
[moz] docs(§20): Issue-Centric Orchestration — Gitea Issue 替代黑板 DB 协作面

Review: 姜维 🚀

结论:Approve(附 3 个需讨论项 + 1 个阻塞项)


整体评价

设计思路清晰——协作面迁到 Gitea Issue、执行面保留 daemon 内部、task_index 做轻量索引。分层合理,§3.1…

jiangwei-infra pushed to main at sanguo/sanguo_moziplus_v2 2026-06-19 01:45:53 +00:00
1c7be0e782 Merge PR #92: [moz] fix(ci): lint venv 残留导致 ensurepip 失败
49d0b3a789 [moz] fix(ci): lint venv 残留导致 ensurepip 失败
Compare 2 commits »
jiangwei-infra closed issue sanguo/sanguo_moziplus_v2#91 2026-06-19 01:45:53 +00:00
[moz] infra: CI lint ensurepip 失败 — act runner Python 环境问题
jiangwei-infra merged pull request sanguo/sanguo_moziplus_v2#92 2026-06-19 01:45:52 +00:00
[moz] fix(ci): lint venv 残留导致 ensurepip 失败
jiangwei-infra commented on issue sanguo/sanguo_moziplus_v2#91 2026-06-19 01:39:42 +00:00
[moz] infra: CI lint ensurepip 失败 — act runner Python 环境问题

修复完成

根因

lint job 创建 /tmp/ci-venv-lint 后不清理。下次 CI 运行时 python3 -m venv 在已有目录上执行 upgrade,ensurepip 调用失败(exit 1)。

test job 已有 `rm -rf /tmp/ci-venv…

jiangwei-infra created pull request sanguo/sanguo_moziplus_v2#92 2026-06-19 01:37:11 +00:00
[moz] fix(ci): lint venv 残留导致 ensurepip 失败
jiangwei-infra pushed to main at sanguo/sanguo_moziplus_v2 2026-06-14 08:31:38 +00:00
b926b35703 Merge PR #75: [moz] fix(ci): 修复 deploy push trigger 不触发问题
8df1d4a83c Merge branch 'main' into fix/cd-push-trigger-yaml
aad5a6b317 [moz] fix(ci): 修复 deploy push trigger 不触发问题
Compare 3 commits »
jiangwei-infra merged pull request sanguo/sanguo_moziplus_v2#75 2026-06-14 08:31:37 +00:00
[moz] fix(ci): 修复 deploy push trigger 不触发问题
jiangwei-infra pushed to fix/cd-push-trigger-yaml at sanguo/sanguo_moziplus_v2 2026-06-14 08:30:23 +00:00
8df1d4a83c Merge branch 'main' into fix/cd-push-trigger-yaml
ad34750075 Merge PR #74: [moz] ci: CI 管道新增 frontend build job
cd7e24cd3c [moz] ci: CI 管道新增 frontend build job(tsc + vite build)
Compare 3 commits »
jiangwei-infra created pull request sanguo/sanguo_moziplus_v2#75 2026-06-14 08:29:00 +00:00
[moz] fix(ci): 修复 deploy push trigger 不触发问题
jiangwei-infra approved sanguo/sanguo_moziplus_v2#65 2026-06-13 16:29:27 +00:00
feat: §17 ToolchainHandler 强约束实现(Step 1-4)

姜维审查意见(infra/部署维度)— APPROVED

jiangwei-infra suggested changes for sanguo/sanguo_moziplus_v2#65 2026-06-13 15:41:18 +00:00
feat: §17 ToolchainHandler 强约束实现(Step 1-4)

姜维审查意见(infra/部署维度)

jiangwei-infra commented on pull request sanguo/sanguo_moziplus_v2#64 2026-06-13 15:04:17 +00:00
refactor(design): §17 toolchain/mail 完全分离——Gitea 为唯一协作媒介

姜维审查意见(infra 维度)

通过

toolchain 和 Mail 完全分离的方向正确。两个系统各司其职,生命周期独立。

infra 侧确认

on_failure 三分路设计合理

  • 业务失败 → PR comment…
jiangwei-infra commented on pull request sanguo/sanguo_moziplus_v2#63 2026-06-13 14:06:13 +00:00
feat(design): §17 ToolchainHandler 强约束设计(取代 action Mail 类型)

姜维审查意见(infra/部署维度)

jiangwei-infra commented on pull request sanguo/sanguo_moziplus_v2#62 2026-06-13 13:33:37 +00:00
feat(design): §17 action Mail 类型设计 v2.0

姜维审查意见(infra/部署维度)

jiangwei-infra closed pull request sanguo/sanguo_moziplus_v2#40 2026-06-12 02:05:48 +00:00
test: webhook event type observation
jiangwei-infra created pull request sanguo/sanguo_moziplus_v2#40 2026-06-12 01:43:44 +00:00
test: webhook event type observation
jiangwei-infra deleted branch test-final-push from sanguo/sanguo_moziplus_v2 2026-06-11 02:04:02 +00:00
jiangwei-infra pushed to test-final-push at sanguo/sanguo_moziplus_v2 2026-06-11 02:04:01 +00:00
a321f9cee4 test: push verification after upgrade