sanguo/moziplus-v2
7
0
Fork 0
Code Issues 4 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

feat: review rejection test #18

Closed
pangtong-fujunshi wants to merge 2 commits from feat/need-revision into main
pull from: feat/need-revision
merge into: sanguo:main
Conversation 4 Commits 2 Files Changed 2
+10
pangtong-fujunshi commented 2026-06-08 14:06:43 +00:00
Member
Copy Link
Copy Source
No description provided.
pangtong-fujunshi added 2 commits 2026-06-08 14:06:43 +00:00
feat: add /api/healthz endpoint (#)
CI / lint (push) Successful in 9s
Details
CI / lint (pull_request) Successful in 6s
Details
CI / test (push) Successful in 4s
Details
CI / test (pull_request) Successful in 4s
Details
CI / notify-on-failure (push) Successful in 2s
Details
CI / notify-on-failure (pull_request) Successful in 3s
Details
7590247f48
feat: intentionally bad code for review rejection test
CI / lint (pull_request) Successful in 8s
Details
CI / lint (push) Successful in 7s
Details
CI / test (pull_request) Successful in 4s
Details
CI / test (push) Successful in 4s
Details
CI / notify-on-failure (pull_request) Successful in 6s
Details
CI / notify-on-failure (push) Successful in 1s
Details
0280074716
simayi-challenger requested changes 2026-06-08 14:07:06 +00:00
Dismissed
simayi-challenger left a comment
Member
Copy Link
Copy Source

S8 test: bad implementation, please fix.

S8 test: bad implementation, please fix.
simayi-challenger requested changes 2026-06-08 14:07:24 +00:00
simayi-challenger left a comment
Member
Copy Link
Copy Source

Review — REQUEST_CHANGES

  1. src/api/bad.py：空文件（1行注释），无业务逻辑，不应合入。如果是故意触发 CI/lint 失败的测试文件，应标注后关闭 PR。

  2. src/api/healthz.py：与 PR #17 相同内容，router 仍未注册到 main.py，端点不会生效。

请清理后重新提交，或关闭此 PR。

Review — REQUEST_CHANGES 1. src/api/bad.py：空文件（1行注释），无业务逻辑，不应合入。如果是故意触发 CI/lint 失败的测试文件，应标注后关闭 PR。 2. src/api/healthz.py：与 PR #17 相同内容，router 仍未注册到 main.py，端点不会生效。 请清理后重新提交，或关闭此 PR。
admin commented 2026-06-08 14:07:45 +00:00
Owner
Copy Link
Copy Source

❌ CI 失败

请检查 CI 日志并修复。

触发 commit: 0280074716c13a66d89cf7decda247aa4b1a69fa

❌ **CI 失败** 请检查 CI 日志并修复。 触发 commit: `0280074716c13a66d89cf7decda247aa4b1a69fa`
admin commented 2026-06-08 14:07:58 +00:00
Owner
Copy Link
Copy Source

❌ CI 失败

请检查 CI 日志并修复。

触发 commit: 0280074716c13a66d89cf7decda247aa4b1a69fa

❌ **CI 失败** 请检查 CI 日志并修复。 触发 commit: `0280074716c13a66d89cf7decda247aa4b1a69fa`
All checks were successful
CI / lint (pull_request) Successful in 8s
Details
CI / lint (push) Successful in 7s
Details
CI / test (pull_request) Successful in 4s
Details
CI / test (push) Successful in 4s
Details
CI / notify-on-failure (pull_request) Successful in 6s
Details
CI / notify-on-failure (push) Successful in 1s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
simayi-challenger
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin guanyu-dev (关羽 风控守将) jiangwei-infra (姜维 平台总督) pangtong-fujunshi (庞统 副军师) simayi-challenger (司马懿 质量总监) zhangfei-dev (张飞 编码先锋) zhaoyun-data (赵云 数据总管)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sanguo/moziplus-v2#18
Delete Branch "feat/need-revision"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?