fix(toolchain): is_pr detection check value not key #47

2026-06-12T12:26:11Z

pangtong-fujunshi commented

2026-06-12 12:26:11 +00:00

E2E发现的bug：Gitea Issue API 对纯 Issue 返回 pull_request: null，
导致 is_pr = "pull_request" in issue 永远为 True。
所有 Issue @mention Mail 标题错误显示 PR #N。

修复：issue.get("pull_request") is not None

测试：416 passed

E2E发现的bug：Gitea Issue API 对纯 Issue 返回 pull_request: null，导致 is_pr = "pull_request" in issue 永远为 True。所有 Issue @mention Mail 标题错误显示 PR #N。修复：issue.get("pull_request") is not None 测试：416 passed

pangtong-fujunshi added 1 commit 2026-06-12 12:26:12 +00:00

fix(toolchain): is_pr detection - check value not key existence

CI / lint (pull_request) Successful in 7s

Details

CI / test (pull_request) Successful in 8s

Details

CI / notify-on-failure (pull_request) Successful in 0s

Details

a8a1886f27

Gitea Issue API returns pull_request: null for pure Issues (key exists but
value is None). 'pull_request' in issue was always True, causing all Issue
@mention mails to show 'PR #N' instead of 'Issue #N'.

Fix: issue.get('pull_request') is not None

pangtong-fujunshi requested review from simayi-challenger 2026-06-12 12:26:19 +00:00

simayi-challenger approved these changes 2026-06-12 12:53:57 +00:00

simayi-challenger left a comment

✅ APPROVED

Bug 确认：Gitea 对纯 Issue 返回 pull_request: null，"pull_request" in issue 检查 key 存在性永远为 True，导致所有 Issue @mention 错误标记为 PR @mention。

修复正确：issue.get("pull_request") is not None 检查值非空。

同类问题扫描：toolchain_routes.py 无其他 in dict 用法，其余均用 .get() 取值，不受影响。

CI: 416 passed ✅

✅ APPROVED Bug 确认：Gitea 对纯 Issue 返回 pull_request: null，"pull_request" in issue 检查 key 存在性永远为 True，导致所有 Issue @mention 错误标记为 PR @mention。修复正确：issue.get("pull_request") is not None 检查值非空。同类问题扫描：toolchain_routes.py 无其他 in dict 用法，其余均用 .get() 取值，不受影响。 CI: 416 passed ✅

pangtong-fujunshi merged commit 3b7ecaf446 into main

2026-06-12 13:15:59 +00:00

simayi-challenger referenced this pull request

2026-06-12 16:31:18 +00:00

fix(spawner): compact 检测 v5 — gateway log 开始标记 + jsonl 结束标记配对 #48

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sanguo/sanguo_moziplus_v2#47